TUI: Unified mentions tweaks + polish mentions rendering#23363
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8dd875041
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
canvrno-oai
changed the title
canvrno-oai
force-pushed
the
canvnro/mentions_cleanup_enable
branch
from
898e68b to
0b55450
Compare
canvrno-oai
force-pushed
the
canvnro/mentions_cleanup_enable
branch
3 times, most recently
from
f62a94c to
911b9cf
Compare
… remove legacy file popup, and improve plugin @mention rendering
… remove legacy file popup, and improve plugin @mention rendering
…or plugin mentions in composer
canvrno-oai
force-pushed
the
canvnro/mentions_cleanup_enable
branch
from
1b1718c to
684482e
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 325669b771
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
canvrno-oai
changed the title
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Ran some local tests with the flag enabled an disabled and it worked as expected.
Approved 👍
2 participants
This change keeps unified @mentions behind the mentions_v2 gate, moves the flag to under-development, and polishes mention rendering/history behavior.
It also adds a few small improvements to the mentions feature around mention rendering and history round-tripping for plugin/tool mentions in message edit scenarios. Plugin selections now insert
@mentions with better casing, and saved history preserves the visible sigil so recalled messages look the same as what the user typed.@sigils when encoding/decoding mention history for tool/plugin paths.@mentions do not reopen the popup and punctuated$mentions still persist to cross-session history.Steps to test
--enable mentions_v2@in the TUI composer and verify filesystem/plugin/skill results are displayed in the unified mentions menu.@popup and confirm the inserted text is an@...mention with casing, then recall/edit the message and confirm it still renders as@....$skillmentions rather than@mentions.@plugin.and($skill)keep their bound mention behavior across editing and history recall.