feat(tui): add OSC 8 web links to rich content#24472
Merged
Merged
Conversation
7809c0f to
094b673
Compare
etraut-openai
approved these changes
May 27, 2026
Collaborator
etraut-openai
left a comment
There was a problem hiding this comment.
Code looks good, and I validated the fix manually
There are merge conflicts the resolve before merging
094b673 to
ab616e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Wrapped URLs in rich TUI output, especially URLs rendered inside Markdown tables, are split across terminal rows. In terminals that support OSC 8 hyperlinks, treating each visible fragment as part of the complete destination enables reliable open-link and copy-link actions even after table layout wraps the URL.
This addresses the semantic-link portion of #12200 and the behavior described in #12200 (comment). It does not change ordinary drag-selection across bordered table rows.
What Changed
http://andhttps://destinations, sanitizes terminal payloads, and applies metadata separately from visible line width/layout.How to Test
https://URL.[https://example.com](mailto:support@example.com); confirm these do not acquire a web OSC 8 destination.Targeted automated coverage exercised Markdown links and exclusions, wrapped and pipe-fallback tables, streaming/transcript overlay propagation, status-link truncation, and rendered word-wrapping cell alignment.
just test -p codex-tuiwas also run; it passed the hyperlink coverage and reproduced two unrelated existing guardian feature-flag test failures.