[codex] Support ui visibility meta for tools#24700
Conversation
gpeal
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 176018e41e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ol-visibility # Conflicts: # codex-rs/codex-mcp/src/connection_manager.rs
| const MCP_UI_VISIBILITY_META_KEY: &str = "visibility"; | ||
| const MCP_UI_MODEL_VISIBILITY: &str = "model"; | ||
|
|
||
| /// Returns whether a tool may be included in model-facing tool declarations. |
There was a problem hiding this comment.
IIUC the shape here is coming from the most recent MCP Apps spec -- accurate? If so would be good to link to the standard in a comment here to explain the shape of the data used.
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
Looks good but let's add an integration test (test_codex()) that checks that app-only tool isn't visible or runnable by model in direct or code-mode model.
3 participants
Summary
Adds support for the same ui.visibility metadata as resources
spec