Skip to content

[codex] Fix hyperlink-aware key-value table rendering#24825

Merged
sayan-oai merged 1 commit into
mainfrom
dev/sayan/fix-tui-record-table-hyperlinks
May 27, 2026
Merged

[codex] Fix hyperlink-aware key-value table rendering#24825
sayan-oai merged 1 commit into
mainfrom
dev/sayan/fix-tui-record-table-hyperlinks

Conversation

@sayan-oai
Copy link
Copy Markdown
Collaborator

Why

The key/value markdown table renderer added in #24636 still operates on Line values, while table cells and rendered table output now carry HyperlinkLine. That mismatch breaks codex-tui compilation on main and would risk losing semantic web-link annotations if corrected by flattening the values.

What changed

  • Make key/value record rendering wrap and emit HyperlinkLine values consistently with the existing grid renderer.
  • Remap wrapped hyperlink ranges and shift them when value content is prefixed by record-mode indentation or labels.
  • Add focused coverage verifying key/value fallback output preserves web-link destinations.

Verification

  • just test -p codex-tui -E 'test(key_value_table_keeps_web_annotations) | test(/table_renders_(key_value_records_when_compact_fragmentation_is_systemic_snapshot|stacked_key_value_records_when_path_column_becomes_too_narrow_snapshot|records_when_multiple_prose_columns_are_starved_snapshot)/)'

@sayan-oai sayan-oai marked this pull request as ready for review May 27, 2026 21:58
Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested the feature on my original PR this fixes and it works as expected. Approved! 👍

@sayan-oai sayan-oai merged commit 090144e into main May 27, 2026
31 checks passed
@sayan-oai sayan-oai deleted the dev/sayan/fix-tui-record-table-hyperlinks branch May 27, 2026 22:11
@github-actions github-actions Bot locked and limited conversation to collaborators May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants