[codex] Fix hyperlink-aware key-value table rendering#24825
Merged
Conversation
fcoury-oai
approved these changes
May 27, 2026
Contributor
fcoury-oai
left a comment
There was a problem hiding this comment.
Smoke tested the feature on my original PR this fixes and it works as expected. Approved! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The key/value markdown table renderer added in #24636 still operates on
Linevalues, while table cells and rendered table output now carryHyperlinkLine. That mismatch breakscodex-tuicompilation onmainand would risk losing semantic web-link annotations if corrected by flattening the values.What changed
HyperlinkLinevalues consistently with the existing grid renderer.Verification
just test -p codex-tui -E 'test(key_value_table_keeps_web_annotations) | test(/table_renders_(key_value_records_when_compact_fragmentation_is_systemic_snapshot|stacked_key_value_records_when_path_column_becomes_too_narrow_snapshot|records_when_multiple_prose_columns_are_starved_snapshot)/)'