Skip to content

Use environment secrets for Azure signing#24859

Merged
shijie-oai merged 1 commit into
mainfrom
dev/shijie/azure-artifact-signing-env
Jun 2, 2026
Merged

Use environment secrets for Azure signing#24859
shijie-oai merged 1 commit into
mainfrom
dev/shijie/azure-artifact-signing-env

Conversation

@shijie-oai
Copy link
Copy Markdown
Collaborator

Summary

  • Move Azure Trusted Signing values out of reusable workflow-call secrets and into the azure-artifact-signing environment scope
  • Attach the Windows signing job to the azure-artifact-signing environment so it can resolve the signing secrets directly
  • Stop inheriting caller secrets for the Windows release reusable workflow

Validation

  • git diff --check -- .github/workflows/rust-release.yml .github/workflows/rust-release-windows.yml
  • ruby -e 'require "yaml"; ARGV.each { |path| YAML.load_file(path); puts "ok #{path}" }' .github/workflows/rust-release.yml .github/workflows/rust-release-windows.yml

@shijie-oai shijie-oai marked this pull request as ready for review June 2, 2026 19:40
@shijie-oai shijie-oai merged commit af18e92 into main Jun 2, 2026
31 checks passed
@shijie-oai shijie-oai deleted the dev/shijie/azure-artifact-signing-env branch June 2, 2026 19:41
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants