Use inject_if_running for active goal steering#24924
Conversation
…goals # Conflicts: # codex-rs/core/src/goals.rs
jif-oai
changed the title
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ning # Conflicts: # codex-rs/ext/goal/src/steering.rs
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21e55c95cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Why
This PR is stacked on #24918, which moves goal steering onto source-labeled internal model context fragments. Active-turn goal steering should use the same running-turn injection path as other runtime steering, so those fragments enter the pending input queue as
ResponseItems through the existingSession::inject_if_runningbehavior instead of through a goal-specific conversion wrapper.What Changed
CodexThread::inject_if_runningbridge for callers that only hold a thread handle.ext/goalactive-turn steering to passResponseItems directly.ResponseItems before injecting them into the running turn.Testing
Not run locally; PR metadata update only.