fix(exec-server): reject websocket requests with Origin headers#24947
Merged
viyatb-oai merged 1 commit intoMay 28, 2026
Conversation
Co-authored-by: Codex noreply@openai.com
joedemesy-oai
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex exec-serverhas a local WebSocket listener, but it did not apply the same browser-origin request handling as theapp-serverWebSocket transport. Requests that carry anOriginheader should not be upgraded by this local transport, keeping both local WebSocket servers consistent and avoiding unexpected browser-initiated connections.What changed
codex-rs/exec-server/src/server/transport.rsthat returns403 Forbiddenfor requests carrying anOriginheader.codex-rs/exec-server/tests/websocket.rsthat covers rejection of anOrigin-bearing WebSocket handshake.Origininitialization and process behavior remains covered by the crate tests.Validation
just test -p codex-exec-servertest phase (186 passed; run outside the parent macOS sandbox so nested sandbox tests can execute)just clippy -p codex-exec-server