Skip to content

Drop the stale debug-client manifest#25063

Merged
jif-oai merged 1 commit into
mainfrom
jif/delete-debug-client-cargo-toml
May 29, 2026
Merged

Drop the stale debug-client manifest#25063
jif-oai merged 1 commit into
mainfrom
jif/delete-debug-client-cargo-toml

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 29, 2026

Deletes codex-rs/debug-client/Cargo.toml as one step in removing the stale app-server debug client.

This intentionally leaves Cargo workspace and lockfile cleanup for a later follow-up PR.

@jif-oai jif-oai changed the title Remove debug client manifest Drop the stale debug-client manifest May 29, 2026
@jif-oai jif-oai marked this pull request as ready for review May 29, 2026 10:49
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7b4d6e35b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1,18 +0,0 @@
[package]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the manifest while it remains a workspace member

Deleting this manifest while codex-rs/Cargo.toml still lists "debug-client" as a workspace member breaks Cargo workspace loading entirely; I checked cargo metadata --no-deps --format-version 1 from codex-rs and it fails with failed to read .../debug-client/Cargo.toml, so any just test -p ..., cargo check, or metadata-based tooling in this workspace will fail until the workspace member is removed in the same change.

Useful? React with 👍 / 👎.

@jif-oai jif-oai merged commit fc8c723 into main May 29, 2026
8 of 31 checks passed
@jif-oai jif-oai deleted the jif/delete-debug-client-cargo-toml branch May 29, 2026 10:51
@github-actions github-actions Bot locked and limited conversation to collaborators May 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant