Add goal extension GoalApi#25096
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de0ba46eb7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jif-oai
changed the title
jif-oai
force-pushed
the
jif/goal-extension-app-server-owner
branch
from
de0ba46 to
f76b1da
Compare
jif-oai
changed the title
jif-oai
changed the title
etraut-openai
left a comment
etraut-openai
left a comment
There was a problem hiding this comment.
Overall, looks good. I like the new abstraction. It will help eliminate distributed business logic about goals.
The name GoalApi initially confused me because it's odd to encapsulate an "API" in an object. Would GoalService make more sense?
I left a few additional comments for you to consider but marked the PR as approved.
…p-server-owner # Conflicts: # codex-rs/ext/goal/src/extension.rs # codex-rs/ext/goal/src/steering.rs
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
GoalApifor thread goal get/set/clear operationsStack
Follow-up app-server wiring PR: #25108
Validation
just fmtjust fix -p codex-goal-extensionjust test -p codex-goal-extension