Skip to content

Check root Python script formatting in CI#25165

Merged
anp-oai merged 4 commits into
mainfrom
codex/format-python-scripts-ci
Jun 1, 2026
Merged

Check root Python script formatting in CI#25165
anp-oai merged 4 commits into
mainfrom
codex/format-python-scripts-ci

Conversation

@anp-oai
Copy link
Copy Markdown
Collaborator

@anp-oai anp-oai commented May 29, 2026

Why

Python files under scripts/ were not covered by the repository formatting recipe or the CI formatting job, so formatting drift could merge unnoticed.

What

  • Add a dedicated scripts/pyproject.toml and scripts/uv.lock so root-script formatting uses a locked Ruff version.
  • Extend just fmt to format root Python scripts and add fmt-scripts-check for CI.
  • Run just fmt-scripts-check from .github/workflows/ci.yml, installing uv through SHA-pinned astral-sh/setup-uv while retaining the uv 0.11.3 pin.
  • Apply Ruff formatting to the root Python scripts, including scripts/just-shell.py, and extend sdk/python/tests/test_artifact_workflow_and_binaries.py to cover the root formatting recipe.
  • Update AGENTS.md so agents run just fmt after code changes anywhere in the repository.

Validation

  • Extended the existing Python SDK workflow test to assert that just fmt includes root Python scripts.

@anp-oai anp-oai changed the title Check formatting for Python scripts Check root Python script formatting in CI May 30, 2026
Comment thread justfile Outdated
Comment thread justfile
@anp-oai
Copy link
Copy Markdown
Collaborator Author

anp-oai commented May 30, 2026

Waiting for #24983 before landing.

@anp-oai anp-oai force-pushed the codex/format-python-scripts-ci branch from 3e0e433 to 046f6a8 Compare June 1, 2026 18:36
@anp-oai anp-oai enabled auto-merge (squash) June 1, 2026 18:43
@anp-oai anp-oai merged commit 281b416 into main Jun 1, 2026
31 checks passed
@anp-oai anp-oai deleted the codex/format-python-scripts-ci branch June 1, 2026 18:50
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants