Skip to content

[codex] Cache remote plugin catalog for suggestions#25457

Merged
xl-openai merged 3 commits into
mainfrom
xl/plugin-remote
Jun 2, 2026
Merged

[codex] Cache remote plugin catalog for suggestions#25457
xl-openai merged 3 commits into
mainfrom
xl/plugin-remote

Conversation

@xl-openai
Copy link
Copy Markdown
Collaborator

@xl-openai xl-openai commented May 31, 2026

Summary

  • cache the global remote plugin catalog when remote plugin listing runs and warm it during startup
  • use the cached remote catalog in plugin install recommendations with canonical plugin@openai-curated-remote ids
  • reuse the session PluginsManager for plugin recommendations so remote cache state is visible on the recommend path
  • skip core installed-state verification for remote plugin install suggestions while leaving local plugin and connector verification unchanged

Testing

  • just fmt
  • git diff --check
  • cargo test -p codex-core list_tool_suggest_discoverable_plugins_includes_cached_remote_global_plugins
  • cargo test -p codex-core remote_plugin_install_suggestions_skip_core_installed_verification
  • cargo test -p codex-app-server plugin_list_includes_remote_marketplaces_when_remote_plugin_enabled

Earlier focused checks during the same branch: codex-tools TUI filter test, request_plugin_install tests, and codex-app-server build.

@xl-openai xl-openai marked this pull request as ready for review May 31, 2026 22:50
@xl-openai xl-openai requested a review from a team as a code owner May 31, 2026 22:50
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f26eed2af7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/tools/handlers/request_plugin_install.rs
Comment thread codex-rs/core/src/plugins/discoverable.rs Outdated
Comment thread codex-rs/core/src/plugins/discoverable.rs Outdated
Comment thread codex-rs/core-plugins/src/manager.rs
Comment thread codex-rs/core-plugins/src/remote/catalog_cache.rs
@xl-openai xl-openai merged commit f2b7251 into main Jun 2, 2026
46 of 47 checks passed
@xl-openai xl-openai deleted the xl/plugin-remote branch June 2, 2026 05:10
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants