fix(tui): clarify footer shortcut overlay hints#25625
Merged
Merged
Conversation
Contributor
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8af949784
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a8af949 to
d2b0024
Compare
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The TUI shortcut overlay used static labels for
TabandCtrl+C, even though both keys change behavior while a task is running. That made the visible help misleading: idleTabsubmits rather than queues, and active-turnCtrl+Cinterrupts rather than exits.Closes #25531.
Closes #25564.
What Changed
Tabassubmit messagewhile idle andqueue messagewhile work is running.Ctrl+Casexitwhile idle andinterruptwhile work is running.How to Test
?while no task is running.tab to submit messageandctrl + c to exit.tab to queue messageandctrl + c to interrupt.Tab; confirm it queues rather than submitting immediately.Targeted tests:
just test -p codex-tui footer_snapshotsjust test -p codex-tui footer_mode_snapshotsValidation Notes
just test -p codex-tuicurrently has two unrelated guardian feature-flag test failures on this base:app::tests::update_feature_flags_disabling_guardian_clears_manual_review_policy_without_historyapp::tests::update_feature_flags_disabling_guardian_clears_review_policy_and_restores_defaultjust argument-comment-lint codex-rs/tui/src/bottom_pane/footer.rscould not run locally because the prebuilt wrapper requiresdotslash; the touched Rust diff was manually inspected for opaque positional literals.