Skip to content

fix(tui): clarify footer shortcut overlay hints#25625

Merged
fcoury-oai merged 2 commits into
mainfrom
fcoury/fix-footer-shortcut-overlay-hints
Jun 1, 2026
Merged

fix(tui): clarify footer shortcut overlay hints#25625
fcoury-oai merged 2 commits into
mainfrom
fcoury/fix-footer-shortcut-overlay-hints

Conversation

@fcoury-oai
Copy link
Copy Markdown
Contributor

Why

The TUI shortcut overlay used static labels for Tab and Ctrl+C, even though both keys change behavior while a task is running. That made the visible help misleading: idle Tab submits rather than queues, and active-turn Ctrl+C interrupts rather than exits.

Closes #25531.
Closes #25564.

What Changed

  • Pass task-running state into the shortcut overlay renderer.
  • Render Tab as submit message while idle and queue message while work is running.
  • Render Ctrl+C as exit while idle and interrupt while work is running.
  • Add snapshot coverage for the active-work shortcut overlay and update idle overlay snapshots.

How to Test

  1. Start Codex and open the shortcut overlay with ? while no task is running.
  2. Confirm the overlay shows tab to submit message and ctrl + c to exit.
  3. Start a task, then open or keep the shortcut overlay visible while work is running.
  4. Confirm the overlay shows tab to queue message and ctrl + c to interrupt.
  5. Type a follow-up prompt during active work and press Tab; confirm it queues rather than submitting immediately.

Targeted tests:

  • just test -p codex-tui footer_snapshots
  • just test -p codex-tui footer_mode_snapshots

Validation Notes

just test -p codex-tui currently has two unrelated guardian feature-flag test failures on this base:

  • app::tests::update_feature_flags_disabling_guardian_clears_manual_review_policy_without_history
  • app::tests::update_feature_flags_disabling_guardian_clears_review_policy_and_restores_default

just argument-comment-lint codex-rs/tui/src/bottom_pane/footer.rs could not run locally because the prebuilt wrapper requires dotslash; the touched Rust diff was manually inspected for opaque positional literals.

@fcoury-oai fcoury-oai marked this pull request as ready for review June 1, 2026 14:27
@fcoury-oai
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a8af949784

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/bottom_pane/footer.rs
@fcoury-oai fcoury-oai force-pushed the fcoury/fix-footer-shortcut-overlay-hints branch from a8af949 to d2b0024 Compare June 1, 2026 14:49
@fcoury-oai
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fcoury-oai fcoury-oai merged commit 4e540b1 into main Jun 1, 2026
31 checks passed
@fcoury-oai fcoury-oai deleted the fcoury/fix-footer-shortcut-overlay-hints branch June 1, 2026 22:41
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TUI shortcut overlay says Ctrl+C exits while running work makes Ctrl+C interrupt TUI footer says Tab queues even when idle Tab submits

2 participants