Skip to content

Fix stale TestAppServer rename in plugin_list test#25705

Merged
bolinfest merged 1 commit into
mainfrom
pr25705
Jun 1, 2026
Merged

Fix stale TestAppServer rename in plugin_list test#25705
bolinfest merged 1 commit into
mainfrom
pr25705

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Jun 1, 2026

Why

#25701 renamed the app-server test harness to TestAppServer, but it raced with #25681, which added a new plugin_list test call site still using the old McpProcess name. Once both changes met on main, app-server test builds failed before running the suite because McpProcess no longer exists in that scope.

This PR fixes that CI break by updating the remaining stale call site to the renamed helper.

What Changed

  • Replaced the McpProcess::new(...) use in codex-rs/app-server/tests/suite/v2/plugin_list.rs with TestAppServer::new(...).
  • Renamed the local variable from mcp to app_server at the same call site to match the helper rename.

Relevant code:

let mut app_server = TestAppServer::new(codex_home.path()).await?;
timeout(DEFAULT_TIMEOUT, app_server.initialize()).await??;
let request_id = app_server
.send_plugin_installed_request(PluginInstalledParams {
cwds: None,
install_suggestion_plugin_names: None,
})
.await?;
let response: JSONRPCResponse = timeout(
DEFAULT_TIMEOUT,
app_server.read_stream_until_response_message(RequestId::Integer(request_id)),

Verification

Not run locally; this is a compile fix for the app-server test harness rename.

@bolinfest bolinfest changed the title ci fix Fix stale TestAppServer rename in plugin_list test Jun 1, 2026
@bolinfest bolinfest requested review from owenlin0 and xl-openai June 1, 2026 22:11
@bolinfest bolinfest merged commit 8ee49a2 into main Jun 1, 2026
29 checks passed
@bolinfest bolinfest deleted the pr25705 branch June 1, 2026 22:14
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant