Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#25701 renamed the app-server test harness to
TestAppServer, but it raced with #25681, which added a newplugin_listtest call site still using the oldMcpProcessname. Once both changes met onmain, app-server test builds failed before running the suite becauseMcpProcessno longer exists in that scope.This PR fixes that CI break by updating the remaining stale call site to the renamed helper.
What Changed
McpProcess::new(...)use incodex-rs/app-server/tests/suite/v2/plugin_list.rswithTestAppServer::new(...).mcptoapp_serverat the same call site to match the helper rename.Relevant code:
codex/codex-rs/app-server/tests/suite/v2/plugin_list.rs
Lines 234 to 246 in aadd9c9
Verification
Not run locally; this is a compile fix for the app-server test harness rename.