Skip to content

[codex] Keep hosted tools visible in code-only mode#25890

Merged
aibrahim-oai merged 7 commits into
mainfrom
dev/keep-hosted-tools-in-code-mode-only
Jun 2, 2026
Merged

[codex] Keep hosted tools visible in code-only mode#25890
aibrahim-oai merged 7 commits into
mainfrom
dev/keep-hosted-tools-in-code-mode-only

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

Why

code_mode_only moved ordinary runtime tools behind exec, but it also hid hosted Responses tools. Hosted web_search and image_generation do not have a nested exec runtime path, so code-only sessions lost those capabilities entirely even when their existing provider, auth, model, and configuration gates passed.

What changed

  • Keep hosted Responses tools top-level in code_mode_only sessions after their existing gates pass.
  • Preserve the existing nested-tool behavior for ordinary runtimes and the direct-only behavior for multi-agent v2 tools.
  • Add planner coverage for code_mode_only with default multi-agent v2 settings, hosted live web search, and hosted image generation.

Verification

  • Added focused regression coverage in codex-rs/core/src/tools/spec_plan_tests.rs.
  • Left execution to CI per repository workflow.

@aibrahim-oai aibrahim-oai requested a review from a team as a code owner June 2, 2026 16:54
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6471508391

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/tools/spec_plan_tests.rs
Comment thread codex-rs/core/src/tools/spec_plan.rs
Copy link
Copy Markdown
Collaborator

@sayan-oai sayan-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add integration test but lgtm

@aibrahim-oai aibrahim-oai merged commit 68e2c8e into main Jun 2, 2026
31 of 32 checks passed
@aibrahim-oai aibrahim-oai deleted the dev/keep-hosted-tools-in-code-mode-only branch June 2, 2026 21:50
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants