Expose standalone image generation in code mode#25923
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61beebce7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fn exposure(&self) -> ToolExposure { | ||
| ToolExposure::DirectModelOnly | ||
| ToolExposure::Direct |
There was a problem hiding this comment.
Add integration coverage for code-mode imagegen
This changes ImageGenerationTool from model-only to Direct, which changes agent tool planning by making image_gen.imagegen available through code-mode nested tools, but the commit does not add an integration test for that user-facing path. The repo's Test authoring guidance says, "Features that change the agent logic MUST add an integration test," so the code-mode exposure/dispatch contract can regress without coverage.
Useful? React with 👍 / 👎.
61beebc to
9d98f6c
Compare
Why
Standalone image generation remained top-level-only in code-mode sessions.
What changed
DirectModelOnlytoDirect.Validation
just test -p codex-image-generation-extension