Skip to content

Expose standalone image generation in code mode#25923

Merged
won-openai merged 5 commits into
mainfrom
codemode_imagegenext
Jun 2, 2026
Merged

Expose standalone image generation in code mode#25923
won-openai merged 5 commits into
mainfrom
codemode_imagegenext

Conversation

@won-openai
Copy link
Copy Markdown
Collaborator

Why

Standalone image generation remained top-level-only in code-mode sessions.

What changed

  • Change imagegen exposure from DirectModelOnly to Direct.
  • Keep direct-mode access while enabling nested code-mode access.
  • Add a focused regression test for the exposure contract.

Validation

  • just test -p codex-image-generation-extension

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61beebce7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fn exposure(&self) -> ToolExposure {
ToolExposure::DirectModelOnly
ToolExposure::Direct
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add integration coverage for code-mode imagegen

This changes ImageGenerationTool from model-only to Direct, which changes agent tool planning by making image_gen.imagegen available through code-mode nested tools, but the commit does not add an integration test for that user-facing path. The repo's Test authoring guidance says, "Features that change the agent logic MUST add an integration test," so the code-mode exposure/dispatch contract can regress without coverage.

Useful? React with 👍 / 👎.

@won-openai won-openai force-pushed the codemode_imagegenext branch from 61beebc to 9d98f6c Compare June 2, 2026 21:25
@won-openai won-openai enabled auto-merge (squash) June 2, 2026 21:29
@won-openai won-openai merged commit bec21c7 into main Jun 2, 2026
31 checks passed
@won-openai won-openai deleted the codemode_imagegenext branch June 2, 2026 22:27
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2026
@won-openai won-openai restored the codemode_imagegenext branch June 2, 2026 22:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants