Conversation
bolinfest
force-pushed
the
pr25926
branch
2 times, most recently
from
964eb85 to
5750eb9
Compare
bolinfest
force-pushed
the
pr25943
branch
2 times, most recently
from
bcaf711 to
8c38bcf
Compare
bolinfest
force-pushed
the
pr25926
branch
2 times, most recently
from
87a13de to
c1485dd
Compare
bolinfest
added a commit
that referenced
this pull request
Jun 2, 2026
## Why `profile_sandbox_mode` was left over from the old selected legacy profile path. Production now always derives permissions without that value, and legacy profile contents are ignored, so keeping a parameter that is always `None` makes `derive_permission_profile` look like it still supports a fallback that no longer exists. ## What Changed - Removed the `profile_sandbox_mode` argument from `ConfigToml::derive_permission_profile`. - Updated the production caller and legacy sandbox-policy test helper to match. - Dropped the stale unselected legacy-profile sandbox test that only protected the removed fallback shape. ## Verification - `just test -p codex-config` - `just test -p codex-core 'config::'` --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/openai/codex/pull/25943). * #25926 * __->__ #25943
bolinfest
force-pushed
the
pr25926
branch
2 times, most recently
from
9f2643d to
9ab5f3c
Compare
bolinfest
changed the title
viyatb-oai
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PermissionProfileis becoming the default way to represent Codex permissions, but the implicit default behavior should stay the same for now::workspace:workspace:read-only:read-onlyThis keeps the existing sandbox semantics while making silent config defaults observable as built-in permission profiles instead of treating the legacy
SandboxPolicyprojection as the primary shape.What Changed
:workspaceoutside unsandboxed Windows).Verification
just fmtjust test -p codex-core 'config::'just test -p codex-configStack created with Sapling. Best reviewed with ReviewStack.