Implement v1 skills extension prompt injection#26167
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The skills extension needs a real turn-time path before host, executor, or remote skills can be routed through it. The previous code was mostly a placeholder catalog/provider sketch, so there was no bounded available-skills fragment, no source-owned
SKILL.mdread, and no place for warnings or per-turn selection state to live.This PR makes
ext/skillsthe authority-preserving flow for listing candidate skills and injecting only explicitly selected main prompts, without adding more of that logic tocodex-core.What changed
main_prompt, display path, short description, dependency metadata, enabled/prompt visibility flags, and authority/package-aware read requests.providers/*modules withSkillProviderSourceandSkillProviders, routing list/read/search calls by source kind and surfacing provider failures as warnings.SKILL.mdmain-prompt truncation before the fragments enter model context.UserInput::Skill, skill-file mentions,skill://...paths, and plain$skilltext mentions, then reads selected prompts through their owning provider.install_with_providersso tests and future host wiring can supply concrete providers.Testing
codex-rs/ext/skills/tests/skills_extension.rscoverage for available-catalog injection, selected prompt injection through the owning provider, and prompt-hidden skills that remain invokable.