Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
エリア枠表示時のラベル重なりと枠線の色ムラを解消しました。
背景や目的
エリア枠をONにした際、空エリアでラベルが重なることや枠線色が揃って見えない問題があったため、視認性を改善する目的で調整しました。
原因: 枠線を実borderで付けることでボックス幅が縮みレイアウトに影響し、ラベルの疑似要素がflex itemとして扱われて空エリアで重なり、枠線がコンテンツの下に回り込んで色ムラに見えていました。
対応: 枠線を絶対配置の疑似要素に変更し、ラベルを絶対配置+最小高さで重なりを回避、枠線/ラベルの重ね順を固定しました。
変更内容
with-borderの最小高さを調整しました。レビュー完了希望日
軽微な改修なので急ぎません。
関連Pull requests/Issues
なし
参考
なし
DB変更の有無
無し
チェックリスト