feat: add 'make test' to v2's workflow

[airween]

what

This PR adds mod_security2 module's own test cases to the GH workflow.

The new job uses the same matrix as the existing one, but we can't use --enable-assertions configure option (which is important with the valid configuration, where we do not use invalid values), because then the test cases which check invalid values would throw an assert error.

why

The module's make tests command hasn't been working for some time, because the PCRE2 modifications weren't applied that code. With some recent PR's those part of code were aligned, so make test works again.

[fzipi]

I'll suggest you also to pin versions to well-known hashes and do not use master for versions unless necessary.

There is a nice tool to do this.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[airween]

I'll suggest you also to pin versions to well-known hashes and do not use master for versions unless necessary.

There is a nice tool to do this.

Sorry to ask, what is the advantage of using this form? Why isn't good to use the current master state?

[fzipi]

I'll suggest you also to pin versions to well-known hashes and do not use master for versions unless necessary.
There is a nice tool to do this.

Sorry to ask, what is the advantage of using this form? Why isn't good to use the current master state?

Supply chain attacks? See:

• https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions, Pin actions to a full length commit SHA
• https://michaelheap.com/pin-your-github-actions/

[airween]

Supply chain attacks? See:

Thanks.

If I'm right, if we use hash's then we should have to care with new releases.

I think this PR is outside of this, so can we skip this change now? Later I try to align these as you suggested with other necessary configuration.

[fzipi]

Sounds good. Renovatebot can take care of that, let's do it in a different pr then.