fix: remove unwanted '\0' string terminator from argument's value#3411
Merged
airween merged 1 commit intoowasp-modsecurity:v2/masterfrom Jul 4, 2025
Merged
fix: remove unwanted '\0' string terminator from argument's value#3411airween merged 1 commit intoowasp-modsecurity:v2/masterfrom
airween merged 1 commit intoowasp-modsecurity:v2/masterfrom
Conversation
Member
Author
|
Cc: @RedXanadu |
|
theseion
approved these changes
Jul 2, 2025
RedXanadu
approved these changes
Jul 4, 2025
RedXanadu
left a comment
RedXanadu
left a comment
There was a problem hiding this comment.
I've tested this over the past few days and can confirm this PR resolves the issue where stray null characters were appearing in ARGS and causing lots of false positives.
No false positives and no unexpected null chars after applying this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
This PR removes the unwanted
\0character from the end of parsed argument value, if theSecParseXmlIntoArgsfeature is enabled and if the node is empty.why
Now if the node is empty the engine adds an extra byte to the argument's value, which is the string terminator. That character will be part of the value, so if the node is
<foo></foo>, the value will be\0with length 1. Then the parsed argument will bexml.foo=\x00- which can cause false positives.