Missing "file_get_contents" and "file_put_contents" hooks on master/9.1

[PVince81]

It looks like we lost these hooks during refactoring ?!

See the hooks triggered by "file_get_contents" and "file_put_contents" here: https://github.com/owncloud/core/blob/v9.0.2/apps/files_sharing/lib/sharedstorage.php#L327

After this commit 6123bad they're gone and don't seem to be triggered from anywhere.

@rullzer @icewind1991

CC @oparoz

[PVince81]

This qualifies as API breakage as there might be apps listening to such hooks.
Since @oparoz raised this issue #23620 before, they might be used by the gallery app.

[oparoz]

Thanks for noticing the problem @PVince81! It's needed to track shared files.

[PVince81]

In theory there might be new ways for doing it, but for the sake of backward compatibility we need to keep these. There was no deprecation notice for those, so they're supposed to stay.

[icewind1991]

I can't find any code in master that uses these hooks

[PVince81]

@icewind1991 what about gallery ?

[PVince81]

In general it is fine to get rid of hooks, but as per API policy we should first deprecate them and announce it publicly. And then after 2-3 years remove them after app devs had time to adjust.

[oparoz]

@PVince81 - Gallery is not using hooks yet as they were not working properly, as documented, until recently.