Allow increasing permissions for share owner#25966
Merged
Conversation
Member
There was a problem hiding this comment.
Is this needed? I'd rather keep the 404 error code if it's documented that way.
Contributor
Author
There was a problem hiding this comment.
Not sure if this is documented at all... But I understand your concern.
Do you want me to revert the code to 404 not found instead of 400 bad request ?
PVince81
force-pushed
the
fix-shareperms-increase-owner
branch
from
d43910b to
979c857
Compare
In some cases, the owner of the share is also recipient through a group share. The owner must still be able to increase permissions in that situation.
PVince81
force-pushed
the
fix-shareperms-increase-owner
branch
from
979c857 to
c3ccd4d
Compare
Contributor
Author
|
@DeepDiver1975 seems we have some corruption in this executor: for the sqlite test |
Contributor
Author
|
Please review @jvillafanez @DeepDiver1975 @butonic, this fixes a sharing regression as well |
Member
|
👍 |
Contributor
Author
|
stable9.1: #26045 |
Contributor
Author
|
stable9: #26187 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow increasing permissions for share owner
In some cases, the owner of the share is also recipient through a group share. The owner must still be able to increase permissions in that situation.
Related Issue
Fixes #25542
Motivation and Context
See #25542 (comment)
How Has This Been Tested?
Manual testing in web UI + automated tests for positive and negative condition.
Types of changes
Checklist:
Backports required
Please review @butonic @VicDeo @jvillafanez @DeepDiver1975 @owncloud/sharing