Improve user list rendering perf by not resorting after every add#26282
Merged
DeepDiver1975 merged 1 commit intomasterfrom Oct 7, 2016
Merged
Improve user list rendering perf by not resorting after every add#26282DeepDiver1975 merged 1 commit intomasterfrom
DeepDiver1975 merged 1 commit intomasterfrom
Conversation
The call to UserList.add() was wrong and was passing "user.lastLogin" as the sort argument which would cause the list to be resorted over and over again for every added item after loading the next page of users.
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @ringmaster and @blizzz to be potential reviewers. |
Member
|
👍 |
Member
|
@PVince81 backport? |
Member
|
oh .. yes .. as per description .... will take care |
DeepDiver1975
pushed a commit
that referenced
this pull request
Oct 7, 2016
…very add (#26282) The call to UserList.add() was wrong and was passing "user.lastLogin" as the sort argument which would cause the list to be resorted over and over again for every added item after loading the next page of users.
DeepDiver1975
pushed a commit
that referenced
this pull request
Oct 7, 2016
…ry add (#26282) The call to UserList.add() was wrong and was passing "user.lastLogin" as the sort argument which would cause the list to be resorted over and over again for every added item after loading the next page of users.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The call to UserList.add() was wrong and was passing "user.lastLogin"
as the sort argument which would cause the list to be resorted over and
over again for every added item after loading the next page of users.
Related Issue
Fixes #26234
Motivation and Context
Improves sorting and wrong call
How Has This Been Tested?
Setup LDAP with many users and scroll down on the users page, see that loading the next page still works. Performance difference was not noticable on my local env.
Screenshots (if appropriate):
Types of changes
Checklist:
Backports
Not critical enough for further backports I think.
Please review @jvillafanez @DeepDiver1975 @butonic @VicDeo