click.edit() Support Editor Paths Containing Spaces

[heyglen]

Environment

• Python 3.6.5
• click 6.7
• Windows 7

When using click.edit(), an editor with a space in the path throws an error. For example : "C:\Program Files\Sublime Text 3\sublime_text.exe"

If I put quotes around the path name in the subprocess.Popen call here the problem is fixed.

Before

            c = subprocess.Popen('%s "%s"' % (editor, filename),
                                 env=environ, shell=True)

After

            c = subprocess.Popen('"%s" "%s"' % (editor, filename),
                                 env=environ, shell=True)

[VictoryChang]

I do not encounter an issue on Mac as I can escape the space and open Sublime Text 3.
message = click.edit(
text='\n\n' + '',
editor='/Applications/Sublime\ Text.app/Contents/SharedSupport/bin/subl')

Releasing Issue, please feel free to take if you work specifically on Windows.

[davidism]

Reverted in #1543 due to issues with quoting on Windows. See #1477 for the next fix. However, even with that fix, you're going to need to quote the command properly, just as you would have to on the command line, as it's otherwise impossible to tell if a string is a command with spaces or a command then arguments. my command --option value arg would need to be "my command" --option value arg.

[heyglen]

What if we make a list of all the stings created by partitioning on the trailing space, testing if each is a file to find the command

import pathlib

def split_command_argument(command_with_arguments):
    command = command_with_arguments
    arguments = ''

    if not pathlib.Path(command).is_file():
        # Iterate through the command prefixes split on the last space testing if each prefix is a valid file:
        #   "C:\Program Files\Sublime Text 3\subl.exe -h"
        #   "C:\Program Files\Sublime Text 3\subl.exe"
        #   "C:\Program Files\Sublime Text"
        #   "C:\Program Files\Sublime"
        #   "C:\Program"

        for _ in range(command_with_arguments.count(' ')):
            # Reverse the string to partion on the last space
            reverse_command = command[::-1]
            _, _, reverse_command = reverse_command.partition(' ')
            command = reverse_command[::-1]
            # Test if the command is a valid file
            if pathlib.Path(command).is_file():
                break
        else:
            raise FileNotFoundError(f'Cannot find editor executable in "{command_with_arguments}"')

        # The arguments are whatever remains when the command is removed
        arguments = command_with_arguments.replace(command, '',1 ).strip()

    return command, arguments


command, arguments = split_command_argument('C:\\Program Files\\Sublime Text 3\\subl.exe -h')

print(f'"{command}" "{arguments}"')