resolve_path differs on Windows depending on Python version

[daddycocoaman]

Hi. There was an issue filed under Typer that gives a full explanation, but basically the use of os.path.realpath in the resolve_path logic for click.Path differs between Python 3.7 and 3.8 on Windows. Prior to 3.8, os.path.realpath did not resolve symlinks. Therefore Click users on Windows using Python 3.7 or lower are getting the wrong results for resolve_path.

More info: https://docs.python.org/3/library/os.path.html#os.path.realpath

[davidism]

I'm not sure what you're proposing click should do here.

[daddycocoaman]

Sorry...I probably should have specified the solution.

This resolve path logic needs to account for symbolic links, particularly for the Windows issue.

The way to do this is to check if the path is a link with os.path.islink, and if it is, then get the path with os.readlink. That seems like the best cross-platform solution, and I don't think it should break anything.

I would normally submit a PR but currently super occupied this month. 🤔

[BALaka-18]

@davidism I'm an MLH Fellow, I am working on this issue.

[davidism]

This is causing issues: #1921, #1958. I'm going to revert this change. Update your Python version if you want the behavior offered in a later Python version. Discussion is on #1921