don't complete args that start with dash after double dash separator

[bertolinocastro]

Preventing Click from trying to complete args that starts with dash after a double dash separator

fixes #1247

[davidism]

Needs test and change log.

[bertolinocastro]

I ran the py.test and tox tests as stated here and I got this fail that seems to already occur before my changes:

tests/test_chain.py::test_multicommand_chaining XFAIL

However, I'm not familiar with those applications and automated testing. So I can't go any further.

Please tell me if I can help with anything else.

[davidism]

You need to add a test and changelong entry for the behavior you changed. That is an xfail message about other code, it's not an error.

[bertolinocastro]

Sorry for that many commits.

I just see that my last commit was decorating the wrong function. I'm going to correct that.

[bertolinocastro]

I think that everything is fine now. Anything else?

Are that many commits a problem? Should I make a new PR from a bare fork with these modifications?

[bertolinocastro]

Closing, as it seems that no one is caring about this issue.

[ThiefMaster]

Closing, as it seems that no one is caring about this issue.

No need for passive-aggressive comments. While everyone loves it when PRs get reviewed and merged within hours, please keep in mind that for most open source projects - including this one - the maintainers do this mostly in their free time.

Are that many commits a problem? Should I make a new PR from a bare fork with these modifications?

No, we can squash when merging. Or you can squash them in git (via interactive rebase) and force-push.
But for future PRs it's a good idea to use a separate branch instead of master in your fork.

[bertolinocastro]

I am really sorry if my last message sounded a bit rude. It was not my intention.

ASAP I will push the finished changes here. I thank you all for your help.

[bertolinocastro]

Please, let me know if anything else is needed. Thank you in advance.

outdated