CliRunner isolation stdin has name and mode#1497
Merged
Merged
Conversation
Collaborator
|
Can confirm the issue and the fix! 👍 |
70b8feb to
7d7809f
Compare
Member
|
Added changelog and test. Rewrote this to use properties instead of messing with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
of CliRunner's isolation contextmanager
fixes #1064
A few more notes:
'name'&'mode'are assigned toself.__dict__as kv-pairs, and not as actual attributes to theselfobject, because b/c theio.TextIOWrapperobject is not writable__getattribute__is used to get the above 2 pseudo-attributes fromself.__dict__.nameattribute when running from CLI, but doesn't when usingCliRunner#1064 also exists in PY2, but this PR does not attempt to address that (since Python 2 support will eventually be dropped)NamedTextIOWrapperis not applied tosys.stderr, since click does not readily make it available as aclick.Fileparameter type