Skip to content

fix completion for sub-command names#1529

Closed
jkowalleck wants to merge 1 commit into
pallets:masterfrom
jkowalleck:bugfix/bashcompletion/commandnames
Closed

fix completion for sub-command names#1529
jkowalleck wants to merge 1 commit into
pallets:masterfrom
jkowalleck:bugfix/bashcompletion/commandnames

Conversation

@jkowalleck
Copy link
Copy Markdown
Contributor

@jkowalleck jkowalleck commented Apr 19, 2020

shell completion for subcommands with custom names is broken.
here is a test and a fix.

this same tests and fixes are available for the 7.x maintenance branch via #1598

@jkowalleck jkowalleck changed the title Bugfix/bashcompletion/commandnames fix completion for sub-command names May 28, 2020
@davidism
Copy link
Copy Markdown
Member

closing in favor of #1598, that will get merged forward

@davidism davidism closed this Jun 21, 2020
@davidism
Copy link
Copy Markdown
Member

davidism commented Aug 7, 2020

Decided I'll just be releasing 8.0 rather than another 7.x bugfix just for this, so I'll reopen this one. That said, this will be incompatible with #1622, which rewrites the entire completion system. Would you check that this is still an issue on that branch and leave a comment if so?

@davidism davidism reopened this Aug 7, 2020
@davidism davidism added the f:completion feature: shell completion label Aug 7, 2020
@jkowalleck
Copy link
Copy Markdown
Contributor Author

jkowalleck commented Aug 8, 2020

Hello @davidism

Decided I'll just be releasing 8.0 rather than another 7.x bugfix just for this, so I'll reopen this one. That said, this will be incompatible with #1622, which rewrites the entire completion system.

i see.

Would you check that this is still an issue on that branch and leave a comment if so?

will write tests for MLH-Fellowship:1484-redesign-completion (#1622) and pullrequest fixes if needed.

@jkowalleck
Copy link
Copy Markdown
Contributor Author

Hello @davidism

reviewed #1622 and found that it does not address the fixes from this very PR.
so i asked the authors of #1622 to have them included via MLH-Fellowship#28

@davidism
Copy link
Copy Markdown
Member

davidism commented Aug 8, 2020

Great, thanks for the help! I'll close this one again.

@davidism davidism closed this Aug 8, 2020
kx-chen pushed a commit to MLH-Fellowship/click that referenced this pull request Aug 19, 2020
kx-chen pushed a commit to MLH-Fellowship/click that referenced this pull request Aug 19, 2020
davidism pushed a commit to MLH-Fellowship/click that referenced this pull request Sep 15, 2020
davidism pushed a commit to MLH-Fellowship/click that referenced this pull request Sep 15, 2020
amy-lei pushed a commit to MLH-Fellowship/click that referenced this pull request Sep 28, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f:completion feature: shell completion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants