tolerate UnsupportedOperation in _winconsole._is_console()#1591
Merged
davidism merged 1 commit intoJun 26, 2020
Conversation
Member
|
Interesting, thanks for the fix! I think this might address some other issues that have been reported when echoing in IDE consoles. |
andy-maier
force-pushed
the
andy/fix-unsupportedoperation
branch
from
6ba39b3 to
f3405fc
Compare
davidism
changed the title
* On Windows, calling 'f.fileno()' in '_winconsole._is_console()' may raise UnsupportedOperation, for example when the pytest 'capsys' fixture is used which captures stdout for testing purposes. This change tolerates that exception and treats it as False. * Added a testcase test_echo_with_capsys() where the output of click.echo() is captured using the pytest capsys fixture. Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
davidism
force-pushed
the
andy/fix-unsupportedoperation
branch
from
f3405fc to
ce23ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
On Windows, calling 'f.fileno()' in '_winconsole._is_console()' may raise
UnsupportedOperation, for example when the pytest 'capsys' fixture is used
which captures stdout for testing purposes.
This change tolerates that exception and treats it as False.
Added a testcase test_echo_with_capsys() where the output of click.echo()
is captured using the pytest capsys fixture.
fixes #1590