Case insensitive shell completions for Choice(..., case_sensitive=False)#1693
Merged
davidism merged 1 commit intoNov 1, 2020
Merged
Conversation
bgschiller
reviewed
Oct 18, 2020
bgschiller
left a comment
There was a problem hiding this comment.
Thanks for the quick PR! It might be worth adding a test for the opposite behavior: that case sensitive choice don't autocomplete when the case doesn't match.
Contributor
Author
|
Sorry for the delay, I have added a test case for this as well and the tests are passing as expected :) |
4fb7d61 to
d5857c8
Compare
Member
|
Refactored to avoid using an inner function. Refactored test to use |
Co-authored-by: David Lord <davidism@gmail.com>
d5857c8 to
b964c1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the logic and a test for checking case insensitive completions for
Choiceinstances which have the argumentcase_sensitive=False.What changed was having the
Choiceclass'shell_complete-method takeself.case_sensitiveinto account when matching on the provided instance choices by using temporary string transforms on theincompleteargument andself.choicesinto all lower case whenself.case_sensitive=False.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed. (NOTE: No test results changed with this contribution, there was 1 failing test though)