Allow custom temp directories with CLIRunner.isolated_filesystem#1715
Merged
Conversation
Diaga
force-pushed
the
maaz/issue-395
branch
from
3c7d58b to
91c9aaf
Compare
flosincapite
approved these changes
Nov 25, 2020
|
Looks good to me! |
davidism
reviewed
Feb 15, 2021
Co-authored-by: David Lord <davidism@gmail.com>
davidism
force-pushed
the
maaz/issue-395
branch
from
91c9aaf to
a9711c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLIRunner.isolated_filesystem accepts a custom argument tempdir. If user specifies custom tempdir, we do not delete it afterwards assuming user will clean up afterwards.
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.