Deprecate click.get_terminal_size() in favor of stdlib shutil.#1737
Merged
Conversation
Since Python 3.3, the stdlib provides the function shutil.get_terminal_size(). Now that the project has dropped Python 2 support, the compatibility shim is no longer necessary. The stdlib version returns a named tuple. So rather than indexing "0", can use the more self-documenting attribute "columns". Docs available at: https://docs.python.org/3/library/shutil.html#shutil.get_terminal_size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Python 3.3, the stdlib provides the function
shutil.get_terminal_size(). Now that the project has dropped Python 2
support, the compatibility shim is no longer necessary.
The stdlib version returns a named tuple. So rather than indexing "0",
can use the more self-documenting attribute "columns".
Docs available at:
https://docs.python.org/3/library/shutil.html#shutil.get_terminal_size
Fixes #1736
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.