Skip to content

add test for not showing default when no default is given#1779

Merged
davidism merged 1 commit into
pallets:masterfrom
b3n4kh:master
Feb 15, 2021
Merged

add test for not showing default when no default is given#1779
davidism merged 1 commit into
pallets:masterfrom
b3n4kh:master

Conversation

@b3n4kh
Copy link
Copy Markdown
Contributor

@b3n4kh b3n4kh commented Feb 15, 2021

Adds a test for a special case when using show_default, but no default is available resulting in [default: None].

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism changed the title Adds Test for https://github.com/pallets/click/pull/1755#issuecomment-779421411 add test for not showing default when no default is given Feb 15, 2021
@davidism davidism merged commit 90a6c78 into pallets:master Feb 15, 2021
@davidism
Copy link
Copy Markdown
Member

I needed to force push to do some cleanup. Since you made the PR from your master branch, you'll need to reset it to be in sync with ours.

git fetch upstream
git reset --hard upstream/master
git push -f origin master

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom default label ignored if default is None

2 participants