Skip to content

Allow styled output in Jupyter on Windows#1793

Merged
davidism merged 1 commit into
pallets:masterfrom
MLH-Fellowship:jupyter-windows-support
Feb 25, 2021
Merged

Allow styled output in Jupyter on Windows#1793
davidism merged 1 commit into
pallets:masterfrom
MLH-Fellowship:jupyter-windows-support

Conversation

@leshnabalara
Copy link
Copy Markdown
Contributor

@leshnabalara leshnabalara commented Feb 24, 2021

It appears that styles work in Jupyter Lab and Notebook, including on Windows, without further changes. Removed the check for Windows.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism force-pushed the jupyter-windows-support branch from 47109bc to 6a1d3e2 Compare February 24, 2021 22:56
@davidism davidism changed the title Add styled output support for JupyterLab and Notebook on Windows Allow styled output in Jupyter on Windows Feb 24, 2021
@davidism davidism added this to the 8.0.0 milestone Feb 24, 2021
@davidism davidism force-pushed the jupyter-windows-support branch from 6a1d3e2 to 6b21018 Compare February 24, 2021 23:51
@davidism davidism force-pushed the jupyter-windows-support branch from 6b21018 to 43d1bcf Compare February 25, 2021 00:35
@davidism davidism merged commit 0805f60 into pallets:master Feb 25, 2021
@davidism davidism deleted the jupyter-windows-support branch February 25, 2021 00:38
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Styled output support for JupyterLab

2 participants