Give Option.show_default higher priority wrt Context.show_default#1964
Merged
Conversation
c294519 to
500e81e
Compare
500e81e to
0d58b4e
Compare
Collaborator
Author
|
@davidism EDIT: nope, this would break the propagation from parent context. |
Collaborator
Author
|
@davidism Give me a shout when it's time to release 8.1.0 and I'll resolve conflicts. |
0d58b4e to
bcd7b77
Compare
Previously, it was the opposite.
bcd7b77 to
144f370
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1963.
After this, a non-null
show_defaultpassed to an option overrides the corresponding context setting.Implementation notes
Option.show_default, addingstrto theUnion.strin the type ofContext.show_defaultbecause, as far as I understand, passing astrmakes sense for dynamic options (not for a global default).Option.DEFAULT_SHOW_DEFAULT = False. If you change your mind about the default, the tests I added don't require any change.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.