Skip to content

allow empty str input in prompt() when confirmation_prompt=True and default=""#2158

Merged
davidism merged 1 commit into
pallets:mainfrom
antazoey:fix/allow-empty-when-confirmation-required
Feb 21, 2022
Merged

allow empty str input in prompt() when confirmation_prompt=True and default=""#2158
davidism merged 1 commit into
pallets:mainfrom
antazoey:fix/allow-empty-when-confirmation-required

Conversation

@antazoey
Copy link
Copy Markdown
Contributor

@antazoey antazoey commented Dec 24, 2021

Check to see if the user inputted nothing (empty str) for their first answer and second answer in the prompt() method when confirmation_prompt=True

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@antazoey antazoey force-pushed the fix/allow-empty-when-confirmation-required branch 2 times, most recently from d2c7c17 to 2f48142 Compare December 24, 2021 00:37
@davidism davidism changed the title fix: allow empty str input in prompt() when confirmation_prompt=True and default="" allow empty str input in prompt() when confirmation_prompt=True and default="" Dec 28, 2021
@davidism davidism added this to the 8.1.0 milestone Dec 28, 2021
@davidism davidism force-pushed the fix/allow-empty-when-confirmation-required branch from 2f48142 to 4f7b255 Compare February 21, 2022 20:18
@davidism davidism merged commit deb1f0e into pallets:main Feb 21, 2022
@antazoey antazoey deleted the fix/allow-empty-when-confirmation-required branch February 22, 2022 00:15
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to allow empty str in prompt when confirmation_prompt=True

2 participants