Improve type hints#2212
Merged
Merged
Conversation
davidism
reviewed
Mar 11, 2022
| name = "choice" | ||
|
|
||
| def __init__(self, choices: t.Sequence[str], case_sensitive: bool = True) -> None: | ||
| def __init__(self, choices: t.Collection[str], case_sensitive: bool = True) -> None: |
Member
There was a problem hiding this comment.
Please revert this. Requiring a sequence was deliberate on my part, as the order may matter for display purposes.
Contributor
Author
There was a problem hiding this comment.
easy enough; force-pushed back to a0bbbf2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the typpe annotation on
@commanddecorator so that whenclsis submitted, the return value is an instance ofcls.In addition, as a small tweak, I lowered the requirement on
choicesofChoicetoCollection-- we only need iteration and length. This wayChoice(choices=somedict.keys())is valid.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.