deprecate base classes BaseCommand and MultiCommand#2591
Merged
Conversation
davidism
force-pushed
the
deprecate-base-classes
branch
from
cdadbe7 to
aa1966f
Compare
davidism
force-pushed
the
deprecate-base-classes
branch
from
aa1966f to
238ee07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing
BaseCommandorMultiCommandfromclickorclick.corewill show a deprecation warning. They subclassCommandandGroup, andisinstanceandissubclasswill still work.CommandCollectionstill exists, but since it subclassesGroupnow it also supports commands on the group itself as well as the other sources.Tests were trivial to update, and nothing failed in the switch. Docs were updated to always use the term "group" instead of "multi command", and some other cleanup was done.
closes #2589
closes #2590