Flush sys.stderr when CliRunner finalizes#2933
Merged
Merged
Conversation
davidism
force-pushed
the
clirunner-flushes-stderr
branch
from
8018638 to
44c5bbc
Compare
davidism
force-pushed
the
clirunner-flushes-stderr
branch
from
44c5bbc to
f3a4363
Compare
Member
|
After some review, I think it's better to leave it in the |
kdeldycke
changed the title
sys.stderr when CliRunner finalizes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a dedicated finalizer for CliRunner streams to collect up these values, which makes the scope of the
finallyblock easy to read and reason about.closes #2682