Bugfix: Make click.progressbar work with codecs.open files#637
Closed
mina-asham wants to merge 59 commits into
Closed
Bugfix: Make click.progressbar work with codecs.open files#637mina-asham wants to merge 59 commits into
mina-asham wants to merge 59 commits into
Conversation
Revert changes made to ``BadOptionUsage.__init__`` in 5f98f57. Additionally, store ``option_name`` on the exception instance to allow programmatic access to it (this matches the behavior of several other exceptions) and document the param in ``BadOptionUsage``'s docstring. Fixes pallets#474.
fix minor doc typo: "pf" -> "of"
Restore option_name parameter to BadOptionUsage
introduce int_types compat to fix python3 type error in _length_hint
Full syntax is here: https://docs.python.org/3/distutils/commandref.html
Simplify MANIFEST.in commands
Add the ability to hide commands and options from help
Fixed a typo in the advanced help docs
'resolve_path' suggests, that it will also call os.path.expanduser(), while in fact it does not. Avoid confusion by stating this in the docstring of :class:`Path`.
Clarify behavior of resolve_path
Add Float Range in Types
issue pallets#393: Usage error should show there is a --help option
Removed unnecessary word.
Update python3.rst
fix external package broken link on CONTRIBUTING
- codecs.open returns a StreamReaderWriter when used with encoding, this object doesn't have a `__len__` attribute, so calling the `len` function on it result in an `AttributeError` instead of a `TypeError` - this will catch the AttributeError as well as the TypeError instead of only catching the later
Contributor
|
Oops, sorry, I thought I could actually cherry-pick your commit with this new GitHub feature. I'll merge manually. |
Contributor
|
Manually applied, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__len__attribute, so calling thelenfunction on it result in anAttributeErrorinstead of aTypeError