Include samesite and secure keys when removing session cookie#3726
Merged
Conversation
Contributor
Author
|
Running |
Member
|
See, pallets/werkzeug#1889 which I think is a blocker for this. |
Contributor
Author
|
@pgjones thanks for the reference. It definitely looks like that PR will be necessary for this functionality. I'll also need to update the werkzeug test session class to have nearly identical changes to your PR. |
696d1b4 to
929fa37
Compare
929fa37 to
18c4fbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
samesitekey is required on empty cookies. When a flasksessionis cleared, the delete cookie logic needs to set the configuredsamesiteandsecurekeys.Requires that pallets/werkzeug#1889 is merged first.