docs: adds typing to an example app#4579
Merged
Merged
Conversation
Member
|
Does mypy check this file when running the typing test env? |
Contributor
Author
|
This solves #4574 |
Contributor
Author
|
@davidism Yes, It does! 👍🏽 |
ecf2eb0 to
3351a86
Compare
Member
|
I moved these from the examples to tests directory, and added the directory to the mypy config so that they are tested automatically. I also did some refactoring to organize additional tests in the future. Based on your I reported two issues to mypy while working on this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Examples of typing for:
fixes #4574