Use timezone aware datetime object on session#4645
Merged
Conversation
Contributor
Author
|
Sorry for not including all the contributing items. Some of the entries if you are open to this change I will do once I update my personal access token (can't work with this repo on the CLI right now due to not having the workflow permission authorized from the CLI) |
Member
|
I updated everything else to be timezone aware, this makes sense too. This case is already treated as UTC in |
Contributor
Author
Please let me know if there is anything else you need and I'll do my best to provide those updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naïve datetime objects are discouraged in https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.