Skip to content

area/ui: Fix bug of disappearing matchers#5245

Merged
yomete merged 4 commits into
mainfrom
selector-hiccups
Oct 29, 2024
Merged

area/ui: Fix bug of disappearing matchers#5245
yomete merged 4 commits into
mainfrom
selector-hiccups

Conversation

@yomete
Copy link
Copy Markdown
Contributor

@yomete yomete commented Oct 29, 2024

Fixes a bug where when in the simple querying mode and you add a new set of label matchers, and then proceed to move the mouse away before adding a label name, operator or value., the label matcher set is removed entirely, which can be frustrating.

Also fixes the bug where the regex input field gets so small and you don't get to see what is being typed.

@yomete yomete requested a review from a team as a code owner October 29, 2024 15:37
@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Oct 29, 2024

🤖 Meticulous spotted visual differences in 122 of 422 screens tested: view and approve differences detected.

Last updated for commit fb06a8d. This comment will update as new commits are pushed.

Copy link
Copy Markdown
Member

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Works like a charm now!

@yomete yomete merged commit 8a3c0b7 into main Oct 29, 2024
@yomete yomete deleted the selector-hiccups branch October 29, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants