Skip to content

area/ui: auto close the group by dropdown when there's an outside click#5381

Merged
yomete merged 1 commit into
mainfrom
auto-dismiss-groupby
Dec 11, 2024
Merged

area/ui: auto close the group by dropdown when there's an outside click#5381
yomete merged 1 commit into
mainfrom
auto-dismiss-groupby

Conversation

@yomete
Copy link
Copy Markdown
Contributor

@yomete yomete commented Dec 11, 2024

Fixes #5378

@yomete yomete requested a review from a team as a code owner December 11, 2024 13:29
@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Dec 11, 2024

🤖 Meticulous spotted visual differences in 4 of 223 screens tested: view and approve differences detected.

Meticulous simulated ~5 hours of user flows against your PR.

Last updated for commit 68d4a3e. This comment will update as new commits are pushed.

Copy link
Copy Markdown
Contributor

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@yomete yomete merged commit c8b98c9 into main Dec 11, 2024
@yomete yomete deleted the auto-dismiss-groupby branch December 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group-by menu doesn't close as expected

2 participants