Skip to content

send "group by" in export requests.#5628

Merged
umanwizard merged 3 commits into
mainfrom
fix-no-lbl-export
May 2, 2025
Merged

send "group by" in export requests.#5628
umanwizard merged 3 commits into
mainfrom
fix-no-lbl-export

Conversation

@umanwizard
Copy link
Copy Markdown
Contributor

Add the "group by" field to the query for pprof download and pprof.me export. This makes it so the selected label set will be available in the exported data.

@umanwizard
Copy link
Copy Markdown
Contributor Author

BTW, the labels still don't show up in pprof.me, but they do show up in the pprof you can download from pprof.me. So I suspect there is another issue on the pprof.me side that needs to be fixed.

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented May 1, 2025

✅ Meticulous spotted 0 visual differences across 311 screens tested: view results.

Meticulous evaluated ~4 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 0eeb036. This comment will update as new commits are pushed.

@brancz
Copy link
Copy Markdown
Member

brancz commented May 2, 2025

Just need to fix that lint, then this lgtm and we can have a separate look at pprof.me, but I suspect we just don't pass the group by labels through correctly in the pprof.me backend.

@umanwizard umanwizard merged commit 1e9e933 into main May 2, 2025
38 checks passed
@brancz brancz deleted the fix-no-lbl-export branch May 5, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants