send "group by" in export requests.#5628
Merged
Merged
Conversation
Contributor
Author
|
BTW, the labels still don't show up in pprof.me, but they do show up in the pprof you can download from pprof.me. So I suspect there is another issue on the pprof.me side that needs to be fixed. |
|
✅ Meticulous spotted 0 visual differences across 311 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 0eeb036. This comment will update as new commits are pushed. |
Member
|
Just need to fix that lint, then this lgtm and we can have a separate look at pprof.me, but I suspect we just don't pass the group by labels through correctly in the pprof.me backend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the "group by" field to the query for pprof download and pprof.me export. This makes it so the selected label set will be available in the exported data.