Skip to content

ui: Iciclechart improved error copy#5634

Merged
manojVivek merged 13 commits into
mainfrom
iciclechart-improved-error-copy
May 7, 2025
Merged

ui: Iciclechart improved error copy#5634
manojVivek merged 13 commits into
mainfrom
iciclechart-improved-error-copy

Conversation

@manojVivek
Copy link
Copy Markdown
Contributor

@manojVivek manojVivek commented May 7, 2025

Includes:

  • Refinements to the previous error messages
  • Option to pass in additional help text through context
  • Disable the selection of iciclechart for non delta profiles

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented May 7, 2025

✅ Meticulous spotted visual differences in 113 of 311 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~4 hours of user flows against your PR.

Last updated for commit 673eeb8. This comment will update as new commits are pushed.

<ErrorContent
errorMessage={
<>
<span>To use the Icicle chart, please switch to a Delta profile.</span>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe just not allow people to select it in those cases in the first place?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX wise I feel this would be better, just not allowing them to select could leave them puzzled on 'why?'.

@manojVivek manojVivek merged commit 9c796e4 into main May 7, 2025
36 of 37 checks passed
@manojVivek manojVivek deleted the iciclechart-improved-error-copy branch May 7, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants