feat: ui: Add support for dashed lines for limit metrics in graphs#5640
Merged
Conversation
Member
Author
|
Will fix this bug, but the overall content of the PR is there, so please review. Thanks! |
Filtered out virtual labels for unique key generation in colors. Introduced a `strokeDasharray` prop to allow dashed lines, applied to limit metrics for visual distinction.
metalmatze
force-pushed
the
ui-metrics-graph-limit
branch
from
ee12e81 to
ff2a43a
Compare
|
✅ Meticulous spotted 0 visual differences across 287 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit ac8f38e. This comment will update as new commits are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filtered out virtual labels for unique key generation in colors. Introduced a
strokeDasharrayprop to allow dashed lines, applied to limit metrics for visual distinction.