pkg/query: Introduce value-offset#5651
Merged
Merged
Conversation
Value offset allows each frame to be rendered in parallel by the frontend instead of recursively. Value offset determines the X offset, the depth of the frame the Y offset, and the cumulative the width. This is the last piece missing that will allow the frontend to do this.
|
✅ Meticulous spotted 0 visual differences across 426 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit a4033a6. This comment will update as new commits are pushed. |
metalmatze
reviewed
May 30, 2025
| parent: row, | ||
| valueOffset: valueOffset, | ||
| }) | ||
| valueOffset += fb.builderCumulative.Value(cr) |
Member
There was a problem hiding this comment.
Ok. So the valueOffset is the offset from the other children relative to the parent's cumulative value, right?
I just wanted to verify that we're not passing the pixel from the frontend and performing some x-y axis math in the backend.
This makes sense to me.
Member
Author
There was a problem hiding this comment.
correct it's the value relative to the total, the frontend can then use that to calculate the position based on the available pixel space
metalmatze
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value offset allows each frame to be rendered in parallel by the frontend instead of recursively. Value offset determines the X offset, the depth of the frame the Y offset, and the cumulative the width.
This is the last piece missing that will allow the frontend to do this.