feat(parcacol): use distinct for label discovery to reduce rows returned#5921
Merged
Conversation
Contributor
Author
|
@brancz could you help review this PR? Thank you. |
brancz
approved these changes
Sep 17, 2025
| Project(logicalplan.DynCol(profile.ColumnLabels)). | ||
| Distinct(logicalplan.DynCol(profile.ColumnLabels)). | ||
| Execute(ctx, func(ctx context.Context, r arrow.Record) error { | ||
| r.Retain() |
Member
|
thanks for the ping, I was on PTO and this pushed it to the top of my inbox |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
ProjectwithDistinctin Querier.Labels. This emits only unique label columns, significantly reducing the number of rows materialized and returned.In my cluster, the query of "Labels" returns more than 100 million rows from the underlying database. This PR reduced it to less than 50,000.